Custom implementation overwriting nested model#44
Merged
LourensVeen merged 4 commits intoMay 13, 2026
Conversation
Contributor
Author
|
This has had some more real-world testing and it seems to work, so ready to merge I think. Need to check for conflicts with 45 and figure out in which order to merge them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying a custom implementation, any existing implementation will be overwritten. If that existing implementation is a model, possibly with submodels itself, then we could end up with one or more models in the configuration that aren't used anymore. (Could, because the same model(s) may be used elsewhere too!).
To avoid ambiguity on which model to run, these models need to be removed, and the algorithm for that only considered the directly overwritten implementation, not any submodels if present. This PR fixes that.
It also fixes a cosmetic problem with serialisation, and adds a bit of debug logging just in case we encounter more problems in the future. Note that those log statements won't be visible in MUSCLE3 unless the manager itself is run with debug logging, which we only do when trying to debug the manager.